Skip to content

Add methods to retrieve doc and/or metadata fields only from SearchHit #77192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romseygeek merged 1 commit into from
Sep 2, 2021
Merged

Add methods to retrieve doc and/or metadata fields only from SearchHit #77192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/src/internalClusterTest/java/org/elasticsearch/search/fields/SearchFieldsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,9 +1120,10 @@ public void testLoadMetadata() throws Exception {
assertSearchResponse(response);
assertHitCount(response, 1);

Map<String, DocumentField> fields = response.getHits().getAt(0).getFields();
Map<String, DocumentField> fields = response.getHits().getAt(0).getMetadataFields();

assertThat(fields.get("field1"), nullValue());
assertThat(fields.get("_routing").getValue().toString(), equalTo("1"));
assertThat(response.getHits().getAt(0).getDocumentFields().size(), equalTo(0));
}
}
16 changes: 15 additions & 1 deletion server/src/main/java/org/elasticsearch/search/SearchHit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,9 +449,23 @@ public void setDocumentField(String fieldName, DocumentField field) {
this.documentFields.put(fieldName, field);
}

/**
* @return a map of metadata fields for this hit
*/
public Map<String, DocumentField> getMetadataFields() {
return Collections.unmodifiableMap(metaFields);
}

/**
* @return a map of non-metadata fields requested for this hit
*/
public Map<String, DocumentField> getDocumentFields() {
return Collections.unmodifiableMap(documentFields);
}

/**
* A map of hit fields (from field name to hit fields) if additional fields
* were required to be loaded.
* were required to be loaded. Includes both document and metadata fields.
*/
public Map<String, DocumentField> getFields() {
if (metaFields.size() > 0 || documentFields.size() > 0) {
Expand Down