Move die with dignity to be a test module #77136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the die with dignity tests to be a test module. The purpose of this is so the _die_with_dignity endpoint is available in snapshot builds, for the purpose of enabling testing orchestration logic that manages what happens to a node after it dies with an OutOfMemoryError.
jasontedor
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jasontedor
commented
Sep 2, 2021
| @@ -25,10 +25,6 @@ | |||
|
|
|||
| public class DieWithDignityPlugin extends Plugin implements ActionPlugin { | |||
|
|
|||
| public DieWithDignityPlugin() { | |||
| assert System.getProperty("die.with.dignity.test") != null : "test should pass the `die.with.dignity.test` property"; | |||
Member
Author
There was a problem hiding this comment.
Because this module is now installed in all snapshot builds, this plugin is loaded in all other test suites where this system property would not be configured. This is why this assertion has to be dropped.
rjernst
approved these changes
Sep 2, 2021
|
|
||
| public void testDieWithDignity() throws Exception { | ||
| // there should be an Elasticsearch process running with the die.with.dignity.test system property | ||
| assertBusy(() -> { |
Member
There was a problem hiding this comment.
Why is this stall necessary? Doesn't the rest test infrastructure not run the tests until ES is up?
Member
Author
There was a problem hiding this comment.
The simple explanation is that I copy/pasted the code below that checks that the die-with-dignity instance has been killed, with the intention of modifying it to remove the busy assert, and change it to a check that the die-with-dignity instance is up. Except, I forgot to remove the busy assert. 🤦♀️
I've removed this now in 3dd8db6.
jasontedor
added a commit
that referenced
this pull request
Sep 3, 2021
This commit moves the die with dignity tests to be a test module. The purpose of this is so the _die_with_dignity endpoint is available in snapshot builds, for the purpose of enabling testing orchestration logic that manages what happens to a node after it dies with an OutOfMemoryError.
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Sep 4, 2021
* master: (128 commits) Mute DieWithDignityIT (elastic#77283) Fix randomization in MlNodeShutdownIT (elastic#77281) Add target_node_name for REPLACE shutdown type (elastic#77151) [DOCS] Adds information about version compatibility headers (elastic#77096) Fix template equals when mappings are wrapped (elastic#77008) Fix TextFieldMapper Retaining a Reference to its Builder (elastic#77251) Move die with dignity to be a test module (elastic#77136) Update task names for rest compatiblity (elastic#75267) [ML] adjusting bwc serialization for elastic#77256 (elastic#77257) Move `index.hidden` from Static to Dynamic settings (elastic#77218) Handle cgroups v2 in `OsProbe` (elastic#77128) Choose postings format from FieldMapper instead of MappedFieldType (elastic#77234) Add segment sorter for data streams (elastic#75195) Update skip after backport (elastic#77212) [ML] adding new defer_definition_decompression parameter to put trained model API (elastic#77189) [ML] Fix bug in inference stats persister for when feature reset is called Only check replicas in cancelling existing recoveries. (elastic#60564) Format `AbstractFilteringTestCase` (elastic#77217) [DOCS] Fixes line breaks. (elastic#77248) Convert 'routing' values in REST API tests to strings ... # Conflicts: # server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 7, 2021
After moving test-die-with-dignity to an external test module (see elastic#77136) we need to ensure the javaRestTests are only triggered in snapshot builds as they fail on non snapshot builds. Fixes elastic#77326
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 7, 2021
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 7, 2021
After moving test-die-with-dignity to an external test module (see elastic#77136) we need to ensure the javaRestTests are only triggered in snapshot builds as they fail on non snapshot builds. Fixes elastic#77326
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the die with dignity tests to be a test module. The purpose of this is so the
_die_with_dignityendpoint is available in snapshot builds, for the purpose of enabling testing orchestration logic that manages what happens to a node after it dies with anOutOfMemoryError.