Remove Node Shutdown API feature flag #76588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the Node Shutdown API feature flag. The Node Shutdown API will now always be available.
gwbrown
added
v8.0.0
:Core/Infra/Node Lifecycle
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
22 tasks
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
sethmlarson
approved these changes
Aug 16, 2021
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
Approved for clients team
When I removed the feature flag, I assumed that we would always have the Node Shutdown APIs, but that turns out not to be the case if xpack isn't enabled. This case was caught by the logic to handle the case where the feature flag wasn't enabled by accident. This commit adds the check we always should have had.
gwbrown
added
auto-backport
Contributor
Author
|
Looks like the 7.15 build failed for the BWC checks. @elasticmachine run elasticsearch-ci/bwc |
Collaborator
💔 Backport failed
To backport manually run |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Aug 18, 2021
* Remove Node Shutdown API feature flag This PR removes the Node Shutdown API feature flag. The Node Shutdown API will now always be available. * Check if xpack is enabled in cleanup When I removed the feature flag, I assumed that we would always have the Node Shutdown APIs, but that turns out not to be the case if xpack isn't enabled. This case was caught by the logic to handle the case where the feature flag wasn't enabled by accident. This commit adds the check we always should have had. * Also check version before tyring cleanup
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2021
* Remove Node Shutdown API feature flag (#76588) * Remove Node Shutdown API feature flag This PR removes the Node Shutdown API feature flag. The Node Shutdown API will now always be available. * Check if xpack is enabled in cleanup When I removed the feature flag, I assumed that we would always have the Node Shutdown APIs, but that turns out not to be the case if xpack isn't enabled. This case was caught by the logic to handle the case where the feature flag wasn't enabled by accident. This commit adds the check we always should have had. * Also check version before tyring cleanup * Fix compilation for backport
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Aug 18, 2021
This PR removes the Node Shutdown API feature flag. The Node Shutdown API will now always be available. * Also check version before tyring cleanup
gwbrown
added a commit
that referenced
this pull request
Aug 18, 2021
This PR removes the Node Shutdown API feature flag. The Node Shutdown API will now always be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Node Shutdown API feature flag.
The Node Shutdown API will now always be available.
Relates #70338