Skip to content

refactor: Add actual index to 403 logs #74157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: Add actual index to 403 logs #74157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions ...n/security/src/main/java/org/elasticsearch/xpack/security/authz/AuthorizationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,6 @@ private ElasticsearchSecurityException denialException(Authentication authentica
return authcFailureHandler.authenticationRequired(action, threadContext);
}
}

String userText = "user [" + authUser.principal() + "]";
// check for run as
if (authentication.getUser().isRunAs()) {
Expand All @@ -637,7 +636,9 @@ private ElasticsearchSecurityException denialException(Authentication authentica
userText = userText + " with roles [" + Strings.arrayToCommaDelimitedString(authentication.getUser().roles()) + "]";
}

String requestIndex = extractRequestIndex(request);
String message = "action [" + action + "] is unauthorized for " + userText;
String debugMessage = message.replaceFirst("]", "]" + requestIndex);
if (context != null) {
message = message + " " + context;
}
Expand All @@ -656,10 +657,30 @@ private ElasticsearchSecurityException denialException(Authentication authentica
}
}

logger.debug(message);
logger.debug(debugMessage);
return authorizationError(message, cause);
}

private String extractRequestIndex(TransportRequest request) {
String description = request.getDescription();
if (description == null) {
return "";
}

String index = null;
if (description.contains("indices")) {
index = description
.replaceFirst("^.+indices[ ]?\\[", "")
.replaceFirst("].*$", "");
} else if (description.contains("index {[")) {
index = description
.replaceFirst("^index \\{\\[", "")
.split("]", 2)[0];
}

return index == null ? "" : String.format("(%s)", index);
}

private class AuthorizationResultListener<T extends AuthorizationResult> implements ActionListener<T> {

private final Consumer<T> responseConsumer;
Expand Down