Skip to content

[Docs] Update cross-document links to Kibana Alerting docs#74034

Merged
ymao1 merged 3 commits intoelastic:masterfrom
ymao1:alerting/update-links
Jun 14, 2021
Merged

[Docs] Update cross-document links to Kibana Alerting docs#74034
ymao1 merged 3 commits intoelastic:masterfrom
ymao1:alerting/update-links

Conversation

@ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 10, 2021

Some recent PRs have moved around some of the alerting docs within the Kibana docs, so some of the links need to be updated.

Relevant PRs:

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jun 10, 2021
@ymao1 ymao1 changed the title Updating cross-document links [Docs] Update cross-document links to Kibana Alerting docs Jun 14, 2021
@ymao1 ymao1 self-assigned this Jun 14, 2021
@ymao1 ymao1 marked this pull request as ready for review June 14, 2021 14:43
@ymao1 ymao1 requested review from gchaps and lcawl June 14, 2021 14:43
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

There is a link in the second paragraph to "Alerting and Actions". Should that be changed to "Alerting"?

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 14, 2021

The change looks good to me.

There is a link in the second paragraph to "Alerting and Actions". Should that be changed to "Alerting"?

@gchaps Updated!

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks!

@ymao1 ymao1 merged commit c727b40 into elastic:master Jun 14, 2021
ymao1 added a commit to ymao1/elasticsearch that referenced this pull request Jun 14, 2021
ymao1 added a commit that referenced this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants