-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Make audit event types more readable #73352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lockewritesdocs
merged 4 commits into
elastic:master
from
lockewritesdocs:docs__audit-settings-list
May 26, 2021
Merged
[DOCS] Make audit event types more readable #73352
lockewritesdocs
merged 4 commits into
elastic:master
from
lockewritesdocs:docs__audit-settings-list
May 26, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
bytebilly
reviewed
May 25, 2021
Contributor
Author
|
@elasticmachine update branch |
albertzaharovits
approved these changes
May 26, 2021
Contributor
albertzaharovits
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a very nice improvement to our audit docs! Thank you Adam!
bytebilly
approved these changes
May 26, 2021
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
May 26, 2021
* [DOCS] Changing event table to a list for easier viewing * Make audit event types more readable * Adding system_access_granted user and cross-links Co-authored-by: Elastic Machine <[email protected]>
lockewritesdocs
pushed a commit
that referenced
this pull request
May 26, 2021
* [DOCS] Changing event table to a list for easier viewing * Make audit event types more readable * Adding system_access_granted user and cross-links Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
lockewritesdocs
pushed a commit
that referenced
this pull request
May 26, 2021
* [DOCS] Changing event table to a list for easier viewing * Make audit event types more readable * Adding system_access_granted user and cross-links Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Security/Audit
X-Pack Audit logging
Team:Docs
Meta label for docs team
Team:Security
Meta label for security team
v7.13.0
v7.14.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs for audit event types are currently in a tabular format, which makes the descriptions difficult to read and the log examples challenging to parse. This change:
system_access_grantedas an event typePreview link: https://elasticsearch_73352.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/audit-event-types.html