Rename 'termsenum' API to 'terms_enum' for better readability#73119
Merged
sethmlarson merged 1 commit intomasterfrom May 17, 2021
Merged
Rename 'termsenum' API to 'terms_enum' for better readability#73119sethmlarson merged 1 commit intomasterfrom
sethmlarson merged 1 commit intomasterfrom
Conversation
elasticsearchmachine
added
the
external-contributor
Contributor
Author
|
I'm curious about the |
markharwood
approved these changes
May 14, 2021
Contributor
markharwood
left a comment
markharwood
left a comment
There was a problem hiding this comment.
Thanks for making this change. It aligns with the policy used on other two-word APIs like field_caps.
Is there anything we need to do to ensure the release notes will include the proper name for the API or are we covered?
I'm not too familiar with how release notes are generated to be honest. The original PR was labelled with "release_highlight` which I understand helps sets some wheels in motion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #66452, raised a concern with @markharwood regarding readability for the new
termsenumAPI when it would be implemented by language clients and suggestedterms_enum. We agreed to rename the API resulting in this PR.Is there anything we need to do to ensure the release notes will include the proper name for the API or are we covered?