Searchable snapshots mounted in the 'hot' phase should be pinned to hot nodes #72696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
force-pushed
the
ilm-searchable-snapshot-hot-tier-preference
branch
from
5c968eb to
d632d26
Compare
joegallo
added
:Data Management/ILM+SLM
joegallo
changed the title
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
Author
|
|
dakrone
approved these changes
May 5, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I left two really minor requests for comments so that we don't lose our reasoning down the line next time we look at this code.
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/MigrateAction.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/MountSnapshotStep.java
Show resolved
Hide resolved
andreidan
reviewed
May 5, 2021
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/MigrateAction.java
Outdated
Show resolved
Hide resolved
...de/src/javaRestTest/java/org/elasticsearch/xpack/ilm/actions/SearchableSnapshotActionIT.java
Outdated
Show resolved
Hide resolved
dakrone
approved these changes
May 14, 2021
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM after addressing Andrei's comment
joegallo
force-pushed
the
ilm-searchable-snapshot-hot-tier-preference
branch
from
f241667 to
46e4ba4
Compare
joegallo
added a commit
that referenced
this pull request
May 18, 2021
joegallo
added a commit
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72340
Some bits of this have the effect of reverting or altering some parts of #68861 (which itself closed #68635) -- so I added @andreidan as a reviewer to make sure he agrees with where we landed here.