[Transform] unmute continuous transform testing on sorted indexes #72692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test randmoness has been disabled due to triggered lucene assertions. The upstream issue seems to have been fixed.
hendrikmuhs
added
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
approved these changes
May 4, 2021
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
It will be good to have these tests around again, Especially as sorted indices allow a huge performance boost for transforms.
This was referenced May 5, 2021
hendrikmuhs
pushed a commit
that referenced
this pull request
May 5, 2021
hendrikmuhs
pushed a commit
that referenced
this pull request
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unmute continuous transform testing on sorted indexes. These extra
test randomness has been disabled due to triggered lucene assertions.
The upstream issue seems to have been fixed.
Note: As this test caused issues in the past and extra test paths are chosen at random, I will defer the 7.x backport for at least a week.