Skip to content

Comments

Update advanced-configuration.asciidoc#72656

Merged
jrodewig merged 1 commit into7.12from
Leaf-Lin-patch-2
May 4, 2021
Merged

Update advanced-configuration.asciidoc#72656
jrodewig merged 1 commit into7.12from
Leaf-Lin-patch-2

Conversation

@Leaf-Lin
Copy link
Contributor

@Leaf-Lin Leaf-Lin commented May 4, 2021

Clarify the files to be modified are in the jvm.options.d/ folder

@Leaf-Lin
Update advanced-configuration.asciidoc
ecda172 
Clarify the files to be modified are in the `jvm.options.d/` folder
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 4, 2021
@Leaf-Lin Leaf-Lin requested a review from jrodewig May 4, 2021 08:26
@lockewritesdocs lockewritesdocs added :Core/Infra/Settings Settings infrastructure and APIs >docs General docs changes v7.12.1 and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 4, 2021
@elasticmachine elasticmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels May 4, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2021

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig added :Core/Infra/Core Core issues without another label v7.12.2 v7.13.1 v7.14.0 v8.0.0 and removed :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.12.1 labels May 4, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 4, 2021
jrodewig
jrodewig approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the clarification @Leaf-Lin.

@jrodewig jrodewig merged commit c46b689 into 7.12 May 4, 2021
@jrodewig jrodewig deleted the Leaf-Lin-patch-2 branch May 4, 2021 12:20
This was referenced May 4, 2021
Merged
Merged
Merged
jrodewig added a commit that referenced this pull request May 4, 2021
@jrodewig @Leaf-Lin
[DOCS] Clarify location of custom JVM options files (#72656) (#72679)
7283107 
Clarify the files to be modified are in the `jvm.options.d/` folder

Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
jrodewig added a commit that referenced this pull request May 4, 2021
@jrodewig @Leaf-Lin
[DOCS] Clarify location of custom JVM options files (#72656) (#72680)
e764c18 
Clarify the files to be modified are in the `jvm.options.d/` folder

Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
jrodewig added a commit that referenced this pull request May 4, 2021
@jrodewig @Leaf-Lin
[DOCS] Clarify location of custom JVM options files (#72656) (#72681)
c853af5 
Clarify the files to be modified are in the `jvm.options.d/` folder

Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrodewig jrodewig jrodewig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team v7.12.2 v7.13.0 v7.14.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Leaf-Lin @elasticmachine @jrodewig @jakelandis @mark-vieira @lockewritesdocs @elasticsearchmachine