In access deny msg, only show indices if resolved #71715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our authorization engine has a short-circuit check for the intended
action the takes place before resolving index names (wildcards).
That is, a requests like
GET /_search
GET /logs-*/_search
GET /logs-20210414/_search
will fail fast if the user does not have read permission on any
indices, and we will never resolve the list of indices that the
request targets.
Consequently, it is impossible to provide the list of denied indices
in the error message because that list does exist (and, in the case of
wildards would be empty even if we did resolve it).
This change updates the access denied message so that it does not
attempt to include the list of indices if the IndiceAccessControl
object has an empty list of denied indices.
Prior to this, we would generate messages such as
action [indices:data/read/search] is unauthorized for user [test]
with roles [test] on indices [],
That "indices []" section is never useful since it does not name any
indices, so it has now been dropped from the message if it is empty.
Relates: elastic#42166, elastic#60357
tvernum
added
>bug
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 19, 2021
Our authorization engine has a short-circuit check for the intended
action the takes place before resolving index names (wildcards).
That is, a requests like
GET /_search
GET /logs-*/_search
GET /logs-20210414/_search
will fail fast if the user does not have read permission on any
indices, and we will never resolve the list of indices that the
request targets.
Consequently, it is impossible to provide the list of denied indices
in the error message because that list does not exist (and, in the
case of wildards would be empty even if we did resolve it).
This change updates the access denied message so that it does not
attempt to include the list of indices if the IndicesAccessControl
object has an empty list of denied indices.
Prior to this, we would generate messages such as
action [indices:data/read/search] is unauthorized for user [test]
with roles [test] on indices [],
That "indices []" section is never useful since it does not name any
indices, so it has now been dropped from the message if it is empty.
Relates: elastic#42166, elastic#60357
Backport of: elastic#71715
tvernum
added a commit
that referenced
this pull request
Apr 19, 2021
Our authorization engine has a short-circuit check for the intended
action the takes place before resolving index names (wildcards).
That is, a requests like
GET /_search
GET /logs-*/_search
GET /logs-20210414/_search
will fail fast if the user does not have read permission on any
indices, and we will never resolve the list of indices that the
request targets.
Consequently, it is impossible to provide the list of denied indices
in the error message because that list does not exist (and, in the
case of wildards would be empty even if we did resolve it).
This change updates the access denied message so that it does not
attempt to include the list of indices if the IndicesAccessControl
object has an empty list of denied indices.
Prior to this, we would generate messages such as
action [indices:data/read/search] is unauthorized for user [test]
with roles [test] on indices [],
That "indices []" section is never useful since it does not name any
indices, so it has now been dropped from the message if it is empty.
Backport of: #71715
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Apr 19, 2021
Our authorization engine has a short-circuit check for the intended
action the takes place before resolving index names (wildcards).
That is, a requests like
GET /_search
GET /logs-*/_search
GET /logs-20210414/_search
will fail fast if the user does not have read permission on any
indices, and we will never resolve the list of indices that the
request targets.
Consequently, it is impossible to provide the list of denied indices
in the error message because that list does not exist (and, in the
case of wildards would be empty even if we did resolve it).
This change updates the access denied message so that it does not
attempt to include the list of indices if the IndicesAccessControl
object has an empty list of denied indices.
Prior to this, we would generate messages such as
action [indices:data/read/search] is unauthorized for user [test]
with roles [test] on indices [],
That "indices []" section is never useful since it does not name any
indices, so it has now been dropped from the message if it is empty.
Backport of: elastic#71715
tvernum
added a commit
that referenced
this pull request
Apr 19, 2021
Our authorization engine has a short-circuit check for the intended
action the takes place before resolving index names (wildcards).
That is, a requests like
GET /_search
GET /logs-*/_search
GET /logs-20210414/_search
will fail fast if the user does not have read permission on any
indices, and we will never resolve the list of indices that the
request targets.
Consequently, it is impossible to provide the list of denied indices
in the error message because that list does not exist (and, in the
case of wildards would be empty even if we did resolve it).
This change updates the access denied message so that it does not
attempt to include the list of indices if the IndicesAccessControl
object has an empty list of denied indices.
Prior to this, we would generate messages such as
action [indices:data/read/search] is unauthorized for user [test]
with roles [test] on indices [],
That "indices []" section is never useful since it does not name any
indices, so it has now been dropped from the message if it is empty.
Backport of: #71715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our authorization engine has a short-circuit check for the intended
action the takes place before resolving index names (wildcards).
That is, a requests like
will fail fast if the user does not have read permission on any
indices, and we will never resolve the list of indices that the
request targets.
Consequently, it is impossible to provide the list of denied indices
in the error message because that list does not exist (and, in the case of
wildards would be empty even if we did resolve it).
This change updates the access denied message so that it does not
attempt to include the list of indices if the IndiceAccessControl
object has an empty list of denied indices.
Prior to this, we would generate messages such as
That "indices []" section is never useful since it does not name any
indices, so it has now been dropped from the message if it is empty.
Relates: #42166, #60357