-
Notifications
You must be signed in to change notification settings - Fork 25.7k
SQL: Fix test to not run as a jdbc driver newer than the server #70674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test simulating running an newer JDBC driver against an older server. This scenario's no longer supported.
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
The mode and subsequent required parameters are all removed, as they aren't needed.
Reenable test.
Remove unused import.
astefan
approved these changes
Mar 23, 2021
Contributor
astefan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bpintea
added a commit
that referenced
this pull request
Mar 23, 2021
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Mar 23, 2021
…tic#70674) Fix test simulating running an newer JDBC driver against an older server. This scenario's no longer supported. Fixes elastic#70630. (cherry picked from commit e6c4ce5)
bpintea
added a commit
that referenced
this pull request
Mar 23, 2021
bpintea
added a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/SQL
SQL querying
Team:QL (Deprecated)
Meta label for query languages team
>test
Issues or PRs that are addressing/adding tests
v7.12.1
v7.13.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test simulating running an newer JDBC driver against an older
server. This scenario's no longer supported (bug fix).
Fixes #70630.