[7.x] [RollupV2] Move rollup metadata to field mappings #70647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves field related rollup metadata from the index metadata to the field mapping metadata.
- date_histogram fields is moved to the timestamp field
(fields are fixed_interval or calendar_interval, time_zone)
- histogram fields are moved to the numeric field on which the the histogram is computed
(the field is named interval)
Also, the index uuid has been added to the index rollup settings as index.rollup.source.uuid
and index.rollup.source.name
The rest of the RollupMetadata has been removed and no rollup metadata exists in the global
cluster state.
Co-authored-by: Tal Levy <[email protected]>
csoulios
added
:StorageEngine/Rollup
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
csoulios
commented
Mar 22, 2021
|
|
||
| // Using the CreateIndexRequest class only to produce the transformation to the mappings map. | ||
| // Alternatively, we would have to copy-paste that part of the code. | ||
| Map<String, String> mappingAsMap = new CreateIndexRequest().mapping("_doc", mapping).mappings(); |
Contributor
Author
There was a problem hiding this comment.
@talevy Do you have any idea if there's a better way to create the mappings map?
Contributor
There was a problem hiding this comment.
XContentHelper.convertToMap(XContentType.JSON.xContent(), Strings.toString(mapping), false)
should get the Map<String, Object>
or
XContentParser parser = null;
Map<String, String> mappingAsMap = null;
try {
parser = xContent.createParser(NamedXContentRegistry.EMPTY, DeprecationHandler.THROW_UNSUPPORTED_OPERATION, Strings.toString(mapping))
mappingAsMap = parser.mapStrings();
} finally {
if (parser != null) {
parser.close();
}
}
I don't know if that is the best way, but the XContentParser#mapStrings looks promising. I wonder what the strategy for changing things between 7.x to 8.0 were here. that technique can likely be leveraged.
Contributor
There was a problem hiding this comment.
I think in the piece of code that I shared a few weeks ago, I just re-used the CreateIndexRequest as you did. I felt it was the most readable at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #69921 to 7.x