[Transform] deprecate "transform.node" node attribute #70234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead. For BWC the node attribute must still be set in 7.x but can be removed in 8.0
elasticsearchmachine
added
the
external-contributor
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs
removed
the
external-contributor
This was referenced Mar 11, 2021
hendrikmuhs
pushed a commit
that referenced
this pull request
Mar 11, 2021
…70291) The node attribute transform.node has been introduced in #52712 (7.7) to implement dedicated transform nodes. A technical limitation in the stack made it necessary to use this workaround. This limitation has been removed by #54998 (7.9). It is now possible to find out, if a node is a transform node without using the node attribute. This PR deprecates the node attribute and bases the placement decision on the node role. The attribute gets unused for placement, however we can not remove the node attribute yet, because in a mixed version cluster the attribute might still be used, especially when master gets updated last. The node attribute will be completely removed in 8, as the upgrade path requires to upgrade to 7.last before upgrading to 8.x. backport #70234
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Mar 15, 2021
The node attribute transform.node has been introduced in elastic#52712 (7.7) to implement dedicated transform nodes. A technical limitation in the stack made it necessary to use this workaround. This limitation has been removed by elastic#54998 (7.9). It is now possible to find out, if a node is a transform node without using the node attribute. This PR deprecates the node attribute and bases the placement decision on the node role. The attribute gets unused for placement, however we can not remove the node attribute yet, because in a mixed version cluster the attribute might still be used, especially when master gets updated last. The node attribute will be completely removed in 8, as the upgrade path requires to upgrade to 7.last before upgrading to 8.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node attribute
transform.nodehas been introduced in #52712 (7.7) to implement dedicated transform nodes. A technical limitation in the stack made it necessary to use this workaround. This limitation has been removed by #54998 (7.9). It is now possible to find out, if a node is a transform node without using the node attribute. This PR deprecates the node attribute and bases the placement decision on the node role. The attribute gets unused for placement, however we can not remove the node attribute yet, because in a mixed version cluster the attribute might still be used, especially whenmastergets updated last. The node attribute will be completely removed in8, as the upgrade path requires to upgrade to7.lastbefore upgrading to8.x.Note:
transform.nodeis an internal implementation detail, setting this attribute from outside is prohibited (throws an exception).