New queryable "_tier" metadata field #69288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jimczi
reviewed
Feb 19, 2021
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
markharwood
force-pushed
the
fix/68135
branch
2 times, most recently
from
2a6fedc to
e86181e
Compare
jpountz
reviewed
Feb 22, 2021
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
markharwood
force-pushed
the
fix/68135
branch
2 times, most recently
from
b5570c7 to
d5c838d
Compare
Contributor
Author
|
@jpountz I commented out the familyTypeName support for now - was breaking some SQL test expectations |
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
Contributor
|
I wonder if the approach taken here allows for sorting by "_tier" too? If so, it would be sort of nice to let the order be "content", "hot", "warm", "cold", "frozen", regardless of alphabetical ordering. Not sure I have a killer case for this though. |
Contributor
Author
|
This PR has two dependencies:
With regards to 1) I suspect we can merge this PR minus sort/aggs support and save for another issue. |
jimczi
reviewed
Mar 5, 2021
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
I left some comments but the logic looks good to me.
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/ConstantFieldType.java
Outdated
Show resolved
Hide resolved
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
...ta-streams/src/main/java/org/elasticsearch/xpack/datastreams/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
markharwood
force-pushed
the
fix/68135
branch
3 times, most recently
from
75b416b to
dca2ded
Compare
jimczi
approved these changes
Mar 31, 2021
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
I left minor comments, LGTM otherwise.
...main/java/org/elasticsearch/xpack/cluster/routing/allocation/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
...main/java/org/elasticsearch/xpack/cluster/routing/allocation/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
…es on the roles defined (explicitly or implicitly)for a node. Closes elastic#68135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New metadata field, like the "_index" field that supports term, terms and wildcard queries on the roles defined (explicitly or implicitly)for a node.
Will add tests if we think this is the way forward
Closes #68135