Skip to content

Compatible API Reindex size field #68355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Compatible API Reindex size field #68355

wants to merge 5 commits into from

Conversation

@pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Feb 2, 2021 •
edited
Loading

The commit #43373 has removed outer level size field in version 7.
This commit allows for the use of the size field in server ES8 using compatible REST API.

relates #51816

@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Feb 2, 2021
@pgomulka pgomulka self-assigned this Feb 2, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Feb 2, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 2, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 2, 2021

test run
./gradlew ':modules:reindex:yamlRestCompatTest' --tests "org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT.test {yaml=reindex/30_search/Sorting and size combined}" -Dtests.seed=D9A0CABA96A1A0E1 -Dtests.security.manager=true -Dtests.locale=fi -Dtests.timezone=Navajo -Druntime.java=15

@mark-vieira
Copy link
Contributor

mark-vieira commented Feb 3, 2021

@elasticmachine update branch

@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 8, 2021

@elasticmachine update branch

@pgomulka pgomulka mentioned this pull request Feb 16, 2021
Merged
@pgomulka
Copy link
Contributor Author

pgomulka commented Feb 17, 2021

closing in favour of surgical approach #69037

@pgomulka pgomulka closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgomulka @elasticmachine @mark-vieira @jakelandis