Remove assertion that makes many test failing#67265
Merged
tlrx merged 1 commit intoelastic:masterfrom Jan 11, 2021
Merged
Conversation
tlrx
added
>non-issue
:Distributed/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Jan 11, 2021
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM! happy to see this go away for now :) thanks
Member
Author
|
Thanks Armin. I should have started by this. |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jan 11, 2021
This commit removes an assertion that makes many tests to fail on CI until elastic#67160 is merged, which has been opened to fix the underlying issues around that assertion tripping (and brings back the assertion). Relates elastic#67160
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Jan 11, 2021
This commit removes an assertion that makes many tests to fail on CI until elastic#67160 is merged, which has been opened to fix the underlying issues around that assertion tripping (and brings back the assertion). Relates elastic#67160
tlrx
added a commit
that referenced
this pull request
Jan 11, 2021
tlrx
added a commit
that referenced
this pull request
Jan 11, 2021
This was referenced Jan 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes an assertion that makes many tests to fail on CI until #67160 is merged, which has been opened to fix the underlying issues around that assertion tripping (and brings back the assertion).
The goal here is to limit test triage workload.