[ML] Fix serialization order for model_size_stats #66015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a backporting mistake, master and 7.x were serializing the members of model_size_stats in different orders. This led to BWC test failures on master. This change makes the ordering in 7.x the same as the ordering in master. It will be tested when the mute done in elastic#65895 is reverted on the master branch. Fixes elastic#65893
Collaborator
|
Pinging @elastic/ml-core (:ml) |
droberts195
pushed a commit
to droberts195/elasticsearch
that referenced
this pull request
Dec 8, 2020
This reverts commit 1cf0a6e. The tests should work now that elastic#66015 is merged. Relates elastic#65893
droberts195
pushed a commit
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a backporting mistake, master and 7.x were
serializing the members of model_size_stats in
different orders. This led to BWC test failures
on master.
This change makes the ordering in 7.x the same as
the ordering in master. It will be tested when
the mute done in #65895 is reverted on the master
branch.
Fixes #65893