[ML] Disable dynamic mapping to DFA dest index #65972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to disable dynamic mapping to the destination index of data frame analytics jobs. If the source index has dynamic mapping disabled, then after reindexing it is possible that we add mappings for fields that were previously unmapped, thus making them eligible features. This is confusing to the user. This commit disables dynamic mapping to the destination index. It makes all result field mappings explicit.
Collaborator
|
Pinging @elastic/ml-core (:ml) |
droberts195
approved these changes
Dec 7, 2020
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM, although I think there is one place where you can make the diagnostics better if a test ever fails in the future
Comment on lines
41
to
46
| Map<String, Object> mergedMappingsMap = mergedMappings.getSourceAsMap(); | ||
| assertThat(mergedMappingsMap.size(), equalTo(2)); | ||
| assertThat(mergedMappingsMap.containsKey("dynamic"), is(true)); | ||
| assertThat(mergedMappingsMap.get("dynamic"), equalTo(false)); | ||
| assertThat(mergedMappingsMap.containsKey("properties"), is(true)); | ||
| assertThat(mergedMappingsMap.get("properties"), equalTo(index1Mappings.get("properties"))); |
There was a problem hiding this comment.
If you constructed a map containing the expected contents, then asserted equality with the merged mappings map then you'd get better feedback in the case of failure - both maps would get printed instead of (for example) just finding out that there were 3 items instead of 2.
przemekwitek
approved these changes
Dec 8, 2020
Contributor
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
Just two nits from my side.
| public void testGetResultMappings() { | ||
| Map<String, Object> resultMappings = new Regression("foo").getResultMappings("results", null); | ||
| assertThat(resultMappings, hasEntry("results.foo_prediction", Collections.singletonMap("type", "double"))); | ||
| assertThat(resultMappings, hasEntry("results.feature_importance", Regression.FEATURE_IMPORTANCE_MAPPING)); |
Contributor
There was a problem hiding this comment.
Could you also add is_training here?
| Map<String, Object> resultMappings = | ||
| new Classification("foo").getResultMappings("results", fieldCapabilitiesResponse); | ||
|
|
||
| assertThat(resultMappings, hasEntry("results.foo_prediction", singletonMap("type", "dummy"))); |
Contributor
There was a problem hiding this comment.
[optional] An alternative which I sometimes find more readable is:
assertThat(resultMappings, allOf(hasEntry(...), ..., hasEntry(...)));
dimitris-athanasiou
deleted the
disable-dynamic-mapping-in-dfa-dest-index
branch
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Dec 8, 2020
We need to disable dynamic mapping to the destination index of data frame analytics jobs. If the source index has dynamic mapping disabled, then after reindexing it is possible that we add mappings for fields that were previously unmapped, thus making them eligible features. This is confusing to the user. This commit disables dynamic mapping to the destination index. It makes all result field mappings explicit. Backport of elastic#65972
dimitris-athanasiou
added a commit
that referenced
this pull request
Dec 8, 2020
We need to disable dynamic mapping to the destination index of data frame analytics jobs. If the source index has dynamic mapping disabled, then after reindexing it is possible that we add mappings for fields that were previously unmapped, thus making them eligible features. This is confusing to the user. This commit disables dynamic mapping to the destination index. It makes all result field mappings explicit. Backport of #65972
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to disable dynamic mapping to the destination
index of data frame analytics jobs. If the source index
has dynamic mapping disabled, then after reindexing it is
possible that we add mappings for fields that were previously
unmapped, thus making them eligible features. This is
confusing to the user.
This commit disables dynamic mapping to the destination index.
It makes all result field mappings explicit.