Fix test sending body as url parameter (backport of #65779) #65969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our test framework randomly sends the body of requests over the `source` parameter. We never send the body if it is more than 2000 bytes becuse our HTTP receiver can't handle lines more the 4096 bytes. The thing is, when we do that 2000 bytes check we do it against the reported length of body, not the body after it has been url encoded. Than url encoding strings can *vastly* increase their size. Which could cause us to send some request over the URL that are longer than 4096 bytes. This fixes that by checking the url encoded length as well. We keep the 2000 byte check of the unencoded length because it is a nice fast check, even if it is a bit inaccurate. Closes elastic#65718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test framework randomly sends the body of requests over the
sourceparameter. We never send the body if it is more than 2000 bytes becuse
our HTTP receiver can't handle lines more the 4096 bytes. The thing is,
when we do that 2000 bytes check we do it against the reported length of
body, not the body after it has been url encoded. Than url encoding
strings can vastly increase their size. Which could cause us to send
some request over the URL that are longer than 4096 bytes.
This fixes that by checking the url encoded length as well. We keep the
2000 byte check of the unencoded length because it is a nice fast check,
even if it is a bit inaccurate.
Closes #65718