Use MapperTestCase for cartesian mappers tests #64705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
elasticmachine
added
the
Team:Analytics
romseygeek
approved these changes
Nov 6, 2020
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM! Good to see more of these being converted, thanks @iverase
| b.field("store", true); | ||
| })); | ||
|
|
||
| SourceToParse sourceToParse = new SourceToParse("test", "1", |
Contributor
There was a problem hiding this comment.
You can also use the source method, which simplifies this a bit:
SourceToParse sourceToParser = source(b -> {
b.startObject(FIELD_NAME).field("x", 2000.1).field("y", 305.6).endObject();
});
Contributor
Author
There was a problem hiding this comment.
I am changing it, I was unhappy with that.
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachin run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the cartesian mapper tests (point and shape fields) so that they use
MapperTestCase. In addition the tests are moved out of InternalclusterTest as they do not need to spin up a cluster any more.