Small Simplifications DiskThresholdDecider #64703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some smaller improvements in the direction of elastic#62275 and removal of some dead code and duplication.
original-brownbear
added
>non-issue
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
elasticmachine
added
the
Team:Distributed (Obsolete)
|
|
||
| // Fail open there is no info available | ||
| final ClusterInfo clusterInfo = allocation.clusterInfo(); | ||
| if (clusterInfo == null) { |
Contributor
Author
There was a problem hiding this comment.
This check is dead code, both calling methods to this method use the clusterInfo before it runs so it's never null here for sure.
Contributor
Author
|
Thanks Henning! |
original-brownbear
deleted the
small-simplification-disk-threshold-decider
branch
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 6, 2020
Some smaller improvements in the direction of elastic#62275 and removal of some dead code and duplication.
original-brownbear
added a commit
that referenced
this pull request
Nov 6, 2020
original-brownbear
restored the
small-simplification-disk-threshold-decider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small thing I still had lying around:
Some smaller improvements in the direction of #62275 and removal of some dead code and duplication.