Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 27, 2020

If the background refresh is running, then the refCount assertion will fail as Engine#refreshIsNeeded can increase the refCount by 2.

Closes #64052

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.11.0 v7.10.1 v6.8.14 labels Oct 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 27, 2020
@dnhatn
Copy link
Member Author

dnhatn commented Oct 27, 2020

run elasticsearch-ci/default-distro

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dnhatn

@dnhatn
Copy link
Member Author

dnhatn commented Oct 27, 2020

run elasticsearch-ci/default-distro

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@dnhatn dnhatn merged commit b245348 into elastic:master Oct 28, 2020
@dnhatn dnhatn deleted the fix-testCreateSearchContextFailure branch October 28, 2020 12:53
@andreidan andreidan added v7.10.0 and removed v7.10.1 labels Oct 28, 2020
@dnhatn dnhatn added v7.10.1 and removed v7.10.0 labels Nov 10, 2020
dnhatn added a commit that referenced this pull request Nov 10, 2020
If a background refresh is running, then the refCount assertion will 
fail as Engine#refreshIsNeeded can increase the refCount by 2.

Closes #64052
dnhatn added a commit that referenced this pull request Nov 10, 2020
If a background refresh is running, then the refCount assertion will 
fail as Engine#refreshIsNeeded can increase the refCount by 2.

Closes #64052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.10.1 v7.11.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SearchServiceTests#testCreateSearchContextFailure

6 participants