-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Busily assert in testCreateSearchContextFailure #64243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dnhatn
merged 2 commits into
elastic:master
from
dnhatn:fix-testCreateSearchContextFailure
Oct 28, 2020
Merged
Busily assert in testCreateSearchContextFailure #64243
dnhatn
merged 2 commits into
elastic:master
from
dnhatn:fix-testCreateSearchContextFailure
Oct 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Member
Author
|
run elasticsearch-ci/default-distro |
jimczi
approved these changes
Oct 27, 2020
Contributor
jimczi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dnhatn
Member
Author
|
run elasticsearch-ci/default-distro |
henningandersen
approved these changes
Oct 28, 2020
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
dnhatn
added a commit
that referenced
this pull request
Nov 10, 2020
If a background refresh is running, then the refCount assertion will fail as Engine#refreshIsNeeded can increase the refCount by 2. Closes #64052
dnhatn
added a commit
that referenced
this pull request
Nov 10, 2020
If a background refresh is running, then the refCount assertion will fail as Engine#refreshIsNeeded can increase the refCount by 2. Closes #64052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
Team:Search
Meta label for search team
>test
Issues or PRs that are addressing/adding tests
v7.10.1
v7.11.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the background refresh is running, then the refCount assertion will fail as Engine#refreshIsNeeded can increase the refCount by 2.
Closes #64052