Use asterisk instead of empty string to clear all cached entries #63907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>test
|
Pinging @elastic/es-security (:Security/Security) |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Oct 21, 2020
…stic#63907) The officially supported way to clearing all entries from a cache is to use wildcard of either * or _all. Though empty string has the same effect, it was never intended. Therefore the tests should not use empty string and this PR changes them to use *.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Oct 21, 2020
…stic#63907) The officially supported way to clearing all entries from a cache is to use wildcard of either * or _all. Though empty string has the same effect, it was never intended. Therefore the tests should not use empty string and this PR changes them to use *.
ywangd
added a commit
that referenced
this pull request
Oct 21, 2020
) (#63989) The officially supported way to clearing all entries from a cache is to use wildcard of either * or _all. Though empty string has the same effect, it was never intended. Therefore the tests should not use empty string and this PR changes them to use *.
ywangd
added a commit
that referenced
this pull request
Oct 21, 2020
) (#63988) The officially supported way to clearing all entries from a cache is to use wildcard of either * or _all. Though empty string has the same effect, it was never intended. Therefore the tests should not use empty string and this PR changes them to use *.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The officially supported way to clearing all entries from a cache is to use wildcard of either
*or_all. Though empty string has the same effect, it was never intended. Therefore the tests should not use empty string. This PR changes them to use*.Resolves: #63885