Add deprecation warning for removed strict_duplicate_detection setting#63500
Merged
williamrandolph merged 9 commits intoelastic:7.xfrom Dec 18, 2020
Merged
Conversation
The setting es.xcontent.strict_duplicate_detection was removed in 7.0 (see elastic#34588). It was an undocumented setting, but enough users relied on it that its absence is causing problems during upgrades. This commit adds a message to the deprecation log if this setting is present at startup.
williamrandolph
added
:Delivery/Packaging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
rjernst
reviewed
Oct 8, 2020
qa/os/src/test/java/org/elasticsearch/packaging/test/ConfigurationTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/bootstrap/Bootstrap.java
Outdated
Show resolved
Hide resolved
mark-vieira
added
Team:Delivery
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine update branch please |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-unix |
pugnascotia
removed
the
:Delivery/Packaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setting es.xcontent.strict_duplicate_detection was removed in 7.0 (see #34588). It was an undocumented setting, but enough users relied on it that its absence is causing problems during upgrades. This commit adds a message to the deprecation log if this setting is present at startup.
I looked at putting the warning in the Java options parser, but it was hard to be sure that a check there was catching all the possible ways that a java setting could be passed to the runtime ES JVM. By putting the check in the bootstrap class, we can check the setting in the same way that it was originally used.
The original ticket requested that Elasticsearch fail to start if the
es.xcontent.strict_duplicate_detectionsetting is present. This PR does not do that. It seems to me that at least one release should have a deprecation warning before moving to failure to start.Relates #60222.