Fix test timeout for health on master failover #63455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testHealthOnMasterFailover could timeout on some of the health requests in the case where an index is added, since the recovery leads to extended test run time. Closes elastic#62690
henningandersen
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
| final int iterations = withIndex ? 10 : 20; | ||
| for (int i = 0; i < iterations; ++i) { | ||
| responseFutures.add(client(node).admin().cluster().prepareHealth().setWaitForEvents(Priority.LANGUID) | ||
| .setWaitForGreenStatus().setMasterNodeTimeout(TimeValue.timeValueMinutes(1)).execute()); |
There was a problem hiding this comment.
Just for my understanding: We took more than 1 minute here to get 20 (empty) shards to recover? Isn't that indicative of some other issue?
There was a problem hiding this comment.
That time could include the 10 master restarts as well as some recovery time. The health call may not be able to respond until the settings are updated below.
original-brownbear
approved these changes
Oct 19, 2020
henningandersen
added a commit
that referenced
this pull request
Oct 21, 2020
testHealthOnMasterFailover could timeout on some of the health requests in the case where an index is added, since the recovery leads to extended test run time. Closes #62690
henningandersen
added a commit
that referenced
this pull request
Oct 21, 2020
testHealthOnMasterFailover could timeout on some of the health requests in the case where an index is added, since the recovery leads to extended test run time. Closes #62690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testHealthOnMasterFailover could timeout on some of the health requests
in the case where an index is added, since the recovery leads to
extended test run time.
Relates #61709
Closes #62690