Skip to content

Update TESTING.asciidoc for recent REST test changes #62841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2020
Merged

Update TESTING.asciidoc for recent REST test changes #62841

merged 3 commits into from
Sep 24, 2020

Conversation

@jakelandis
Copy link
Contributor

@jakelandis jakelandis commented Sep 23, 2020

  • Remove reference to Runner (no longer valid)
  • Remove tests.rest (no longer valid)
  • Add reference to javaRestTest
  • Brief mention of qa tests

@jakelandis jakelandis added >non-issue >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure v8.0.0 v7.10.0 labels Sep 23, 2020
@jakelandis jakelandis requested a review from matriv September 23, 2020 19:29
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 23, 2020

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Sep 23, 2020
rjernst
rjernst reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine but I don't understand why we would add info logging.

TESTING.asciidoc Outdated

---------------------------------------------------------------------------
./gradlew :rest-api-spec:yamlRestTest
./gradlew :rest-api-spec:yamlRestTest --info
Copy link
Member

@rjernst rjernst Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding --info logging? This seems unnecessary?

Copy link
Contributor Author

@jakelandis jakelandis Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor preference so that it shows the individual tests that are executing vs. just a test counter counting up. I don't have a strong preference, but have found myself always using --info for rest tests.

I'll defer to your preference @rjernst and remove the --info.

matriv
matriv approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from ryan's question.

@jakelandis jakelandis merged commit ce9e2fd into elastic:master Sep 24, 2020
@jakelandis jakelandis deleted the testing_doc branch September 24, 2020 16:45
@jakelandis jakelandis mentioned this pull request Sep 24, 2020
Merged
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Sep 24, 2020
@jakelandis
Update TESTING.asciidoc for recent REST test changes (elastic#62841)
f353dc6 
* Remove reference to Runner (no longer valid)
* Remove tests.rest (no longer valid)
* Add reference to javaRestTest
* Brief mention of qa tests
# Conflicts:
#	TESTING.asciidoc
jakelandis added a commit that referenced this pull request Oct 1, 2020
@jakelandis
[7.xUpdate TESTING.asciidoc for recent REST test changes (#62841) (#6…
294f40d 
…2895)

* Remove reference to Runner (no longer valid)
* Remove tests.rest (no longer valid)
* Add reference to javaRestTest
* Brief mention of qa tests
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst left review comments

+1 more reviewer

@matriv matriv matriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakelandis @elasticmachine @rjernst @matriv @mark-vieira