Deprecate Repository Stats API #62297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Contributor
|
@tlrx I'm all for this, but I wonder, did we ever document this API in a way that means we can't just remove it outright? |
Member
Author
|
There was a bit of documentation (which has been removed in #62217). This is experimental API hidden behind a feature flag of a not yet release feature so I was also wondering how to remove this. But we have processes to remove APIs... so I'm just following them in case something somewhere is using this (which I don't expect). |
original-brownbear
approved these changes
Sep 14, 2020
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, lets do it the official way :)
Member
Author
|
Thanks Armin! |
tlrx
added a commit
that referenced
this pull request
Sep 14, 2020
This commit deprecates the Repository Stats API added in 7.8.0 as an experimental API behind a feature flag. The goal is to deprecate this API in 7.10.0 and remove it in a follow up PR in 8.0.0. This API is now superseded by the Repositories Metering API.
tlrx
added a commit
that referenced
this pull request
Sep 24, 2020
Now the Repository Stats API is deprecated in 7.10.0 (#62297) we can remove it in 8.0.0. I'm labeling this as >breaking to respect the development process but we're talking about an experimental API that was never released (behind a feature flag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates the Repository Stats API added in 7.8.0 as an experimental API behind a feature flag. The goal is to deprecate this API in 7.10.0 and remove it in a follow up PR in 8.0.0.
This API is now superseded by the Repositories Metering API added in 7.10.0.