[DOCS] [7.9] Update audit-settings.asciidoc#61610
Merged
lockewritesdocs merged 2 commits into7.9from Aug 27, 2020
Merged
Conversation
"I think" all {ess-icon} should be replaced by {ece-icon} because:
- audit logging is not allowed on ESS, as per https://www.elastic.co/guide/en/cloud/current/ec-add-user-settings.html and https://www.elastic.co/guide/en/cloud/current/ec-restrictions.html#ec-restrictions-security
- audit logging is allowed setting on ECE, as per https://www.elastic.co/guide/en/cloud-enterprise/current/ece-enable-auditing.html
Contributor
|
@Leaf-Lin, thanks for bringing this issue to attention. I chatted with @AlexP-Elastic on the Cloud team, and he indicated that audit settings are currently not in the allowlist for ESS, so the icons should not indicate ESS support (as you mentioned). Further, we should not indicate support on ECE, which has no allowlist. All Elasticsearch settings are supported on ECE, so adding an icon for just these settings doesn't make sense. That's partly why we added only ESS icons in both the Kibana and Elasticsearch docs. I'll remove the ESS icons entirely for the settings that you indicated and backport those changes accordingly through 7.8 |
lockewritesdocs
approved these changes
Aug 27, 2020
Contributor
lockewritesdocs
left a comment
lockewritesdocs
left a comment
There was a problem hiding this comment.
Removing ESS icons entirely based on discussion with Cloud engineers.
lockewritesdocs
changed the title
Collaborator
|
Pinging @elastic/es-docs (>docs) |
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 27, 2020
* Update audit-settings.asciidoc
"I think" all {ess-icon} should be replaced by {ece-icon} because:
- audit logging is not allowed on ESS, as per https://www.elastic.co/guide/en/cloud/current/ec-add-user-settings.html and https://www.elastic.co/guide/en/cloud/current/ec-restrictions.html#ec-restrictions-security
- audit logging is allowed setting on ECE, as per https://www.elastic.co/guide/en/cloud-enterprise/current/ece-enable-auditing.html
* Removing ESS icons for audit settings
Co-authored-by: Adam Locke <adam.locke@elastic.co>
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 27, 2020
* Update audit-settings.asciidoc
"I think" all {ess-icon} should be replaced by {ece-icon} because:
- audit logging is not allowed on ESS, as per https://www.elastic.co/guide/en/cloud/current/ec-add-user-settings.html and https://www.elastic.co/guide/en/cloud/current/ec-restrictions.html#ec-restrictions-security
- audit logging is allowed setting on ECE, as per https://www.elastic.co/guide/en/cloud-enterprise/current/ece-enable-auditing.html
* Removing ESS icons for audit settings
Co-authored-by: Adam Locke <adam.locke@elastic.co>
lockewritesdocs
pushed a commit
that referenced
this pull request
Aug 27, 2020
* Update audit-settings.asciidoc
"I think" all {ess-icon} should be replaced by {ece-icon} because:
- audit logging is not allowed on ESS, as per https://www.elastic.co/guide/en/cloud/current/ec-add-user-settings.html and https://www.elastic.co/guide/en/cloud/current/ec-restrictions.html#ec-restrictions-security
- audit logging is allowed setting on ECE, as per https://www.elastic.co/guide/en/cloud-enterprise/current/ece-enable-auditing.html
* Removing ESS icons for audit settings
Co-authored-by: Adam Locke <adam.locke@elastic.co>
Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
Contributor
lockewritesdocs
pushed a commit
that referenced
this pull request
Aug 27, 2020
* Update audit-settings.asciidoc
"I think" all {ess-icon} should be replaced by {ece-icon} because:
- audit logging is not allowed on ESS, as per https://www.elastic.co/guide/en/cloud/current/ec-add-user-settings.html and https://www.elastic.co/guide/en/cloud/current/ec-restrictions.html#ec-restrictions-security
- audit logging is allowed setting on ECE, as per https://www.elastic.co/guide/en/cloud-enterprise/current/ece-enable-auditing.html
* Removing ESS icons for audit settings
Co-authored-by: Adam Locke <adam.locke@elastic.co>
Co-authored-by: Leaf-Lin <39002973+Leaf-Lin@users.noreply.github.com>
Contributor
Author
|
Thank you. I am aware of the allowlist on ESS vs disallowed list on ECE. It makes some sense not to include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"I think" all
{ess-icon}should be replaced by{ece-icon}because:I've also added one more
{ece-icon}for the settingxpack.security.audit.enabledwhich is used to enable them all. I believe this is necessary.Please also make changes to other applicable versions.