Refactor extendedBounds to use DoubleBounds #60556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors extendedBounds to use DoubleBounds instead of 2 variables. This is a follow up for elastic#59175
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
not-napoleon
approved these changes
Aug 3, 2020
Member
not-napoleon
left a comment
not-napoleon
left a comment
There was a problem hiding this comment.
LGTM. Thanks for cleaning this up.
| if (minDocCount == 0) { | ||
| emptyBucketInfo = new EmptyBucketInfo(interval, offset, minBound, maxBound, buildEmptySubAggregations()); | ||
| emptyBucketInfo = new EmptyBucketInfo(interval, offset, | ||
| extendedBounds == null || extendedBounds.getMin() == null ? Double.POSITIVE_INFINITY : extendedBounds.getMin(), |
Member
There was a problem hiding this comment.
Nit: Could we provide a default DoubleBounds(null, null) in the constructor, and then just call DoubleBounds#effectiveMin here? (ditto for max and the below usage). Especially since the logic for what to use for undefined is a little arbitrary (e.g. it's not obvious at a glance why we use POSITIVE_INFINITY instead of NAN), I'd rather just keep that logic in one place if possible.
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Aug 4, 2020
Refactors extendedBounds to use DoubleBounds instead of 2 variables. This is a follow up for elastic#59175
imotov
added a commit
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors extendedBounds to use DoubleBounds instead
of 2 variables.
This is a follow up for #59175