Properly document keepalive and other tcp options #60216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
elasticmachine
added
Team:Docs
DaveCTurner
reviewed
Jul 27, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Ah, I misunderstood #59278 as only applying to transport connections. Since it applies to everything, we should say in the docs that the transport settings default to the corresponding network.tcp.* setting rather than saying they default to -1.
DaveCTurner
reviewed
Jul 27, 2020
ywelsch
requested review from
DaveCTurner and
jrodewig
and removed request for
DaveCTurner
Co-authored-by: David Turner <[email protected]>
Co-authored-by: David Turner <[email protected]>
Co-authored-by: David Turner <[email protected]>
jrodewig
approved these changes
Jul 27, 2020
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
Docs LGTM. I appreciate you updating the formatting of the transport settings.
I left some minor rewording suggestions. Please take or leave those as you like.
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Contributor
Author
|
@elasticmachine update branch |
DaveCTurner
approved these changes
Jul 28, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM (nit: line lengths are a bit wonky now)
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Jul 28, 2020
Keepalive options are not well-documented (only in transport section, although also available at http and network level). Co-authored-by: David Turner <[email protected]> Co-authored-by: James Rodewig <[email protected]>
ywelsch
added a commit
that referenced
this pull request
Jul 28, 2020
Keepalive options are not well-documented (only in transport section, although also available at http and network level). Co-authored-by: David Turner <[email protected]> Co-authored-by: James Rodewig <[email protected]>
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 10, 2020
Followup to elastic#60216, fixing the formatting of `transport.tcp.reuse_address` and clarifying some wording around the distinction between the transport and HTTP layers.
DaveCTurner
added a commit
that referenced
this pull request
Aug 13, 2020
Followup to #60216, fixing the formatting of `transport.tcp.reuse_address` and clarifying some wording around the distinction between the transport and HTTP layers.
DaveCTurner
added a commit
that referenced
this pull request
Aug 13, 2020
Followup to #60216, fixing the formatting of `transport.tcp.reuse_address` and clarifying some wording around the distinction between the transport and HTTP layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keepalive options are not well-documented (only in transport section, although also available at http and network level).