[DOCS] Refactored index-templates topic.#59737
Merged
debadair merged 14 commits intoelastic:masterfrom Jul 24, 2020
Merged
Conversation
debadair
added
>docs
debadair
force-pushed
the
component-templates
branch
2 times, most recently
from
ba87a66 to
23b0af4
Compare
debadair
force-pushed
the
component-templates
branch
from
c18b6a1 to
1b2939c
Compare
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
elasticmachine
added
Team:Data Management (obsolete)
jrodewig
approved these changes
Jul 22, 2020
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
LGTM.
I think there is room for improvement for the Index templates page, but we can handle that as part of later iterations.
It may also be helpful to introduce index settings, mappings, and aliases before index templates in the TOC. However, that also can be part of a later work effort.
Thanks for doing this! I think this is a great move forward.
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
debadair
force-pushed
the
component-templates
branch
from
38d8b64 to
c74d88d
Compare
Contributor
Author
|
Agree there's room for improvement content-wise. The main focus here was getting things refactored. |
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
Jul 24, 2020
* [DOCS] Refactored index-templates topic. * [DOCS] Add separate files. * [DOCS] Add delete component template. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Incorporated review comments
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
Jul 24, 2020
* [DOCS] Refactored index-templates topic. * [DOCS] Add separate files. * [DOCS] Add delete component template. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Incorporated review comments
debadair
added a commit
that referenced
this pull request
Jul 24, 2020
* [DOCS] Refactored index-templates topic. * [DOCS] Add separate files. * [DOCS] Add delete component template. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Incorporated review comments
debadair
added a commit
that referenced
this pull request
Jul 24, 2020
* [DOCS] Refactored index-templates topic. * [DOCS] Add separate files. * [DOCS] Add delete component template. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Incorporated review comments
debadair
added a commit
to debadair/elasticsearch
that referenced
this pull request
Jul 29, 2020
* [DOCS] Refactored index-templates topic. * [DOCS] Add separate files. * [DOCS] Add delete component template. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Incorporated review comments
debadair
added a commit
that referenced
this pull request
Jul 29, 2020
* [DOCS] Refactored index-templates topic. (#59737) * [DOCS] Refactored index-templates topic. * [DOCS] Add separate files. * [DOCS] Add delete component template. * Apply suggestions from code review Co-authored-by: James Rodewig <james.rodewig@elastic.co> * [DOCS] Incorporated review comments * [DOCS] Remove refs to data streams. * [DOCS] Fix test failure * Fixed build error. * Removing unused file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: