Skip to content

Conversation

@costin
Copy link
Member

@costin costin commented Jul 15, 2020

Case sensitivity is incorporated as a test dimension - instead of
running the same test twice, two different tests are created.
Clean-up the test invocation by removing unused parameters.

Fix #59294

Case sensitivity is incorporated as a test dimension - instead of
running the same test twice, two different tests are created.
Clean-up the test invocation by removing unused parameters.

Fix elastic#59294
@costin costin added the :Analytics/EQL EQL querying label Jul 15, 2020
@costin costin requested review from astefan and matriv July 15, 2020 13:23
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jul 15, 2020
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 72c8a35 into elastic:master Jul 15, 2020
@costin costin deleted the fix-59294 branch July 15, 2020 14:55
costin added a commit that referenced this pull request Jul 15, 2020
Case sensitivity is incorporated as a test dimension - instead of
running the same test twice, two different tests are created.
Clean-up the test invocation by removing unused parameters.

Fix #59294

(cherry picked from commit 72c8a35)
costin added a commit that referenced this pull request Jul 15, 2020
Case sensitivity is incorporated as a test dimension - instead of
running the same test twice, two different tests are created.
Clean-up the test invocation by removing unused parameters.

Fix #59294

(cherry picked from commit 72c8a35)
(cherry picked from commit 6b75525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EQL: integration test should create different tests for case sensitivity instead of dual running

3 participants