Ignore test seed used in test system properties #58789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Member
|
Thanks @mark-vieira - I did not know about this. |
mark-vieira
added a commit
that referenced
this pull request
Jul 1, 2020
mark-vieira
added a commit
that referenced
this pull request
Jul 1, 2020
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #58664. By including the build test seed as a system property here we break the build cache since the changing test seed will cause the test task inputs to continually change. We need to flag this as a "non-input" system property so we ignore it when snapshotting task inputs.
CC @tlrx