Skip to content

Conversation

@gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Jun 25, 2020

Relates to #57625.

The main changes are:

  1. Fix custom params are missing when using template or script in watcher's logging action or jira action.
  2. Add yaml tests to test passing params to template or script successfully.

@gaobinlong gaobinlong changed the title Fix passing params to template or script failed Fix passing params to template or script failed in watcher Jun 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Watcher)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 30, 2020
@jakelandis jakelandis self-requested a review July 2, 2020 14:49
@jakelandis
Copy link
Contributor

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@jakelandis
Copy link
Contributor

@elasticmachine ok to test

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. thanks @gaobinlong !

@jakelandis jakelandis merged commit 500e12f into elastic:master Sep 2, 2020
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Sep 2, 2020
…8559)

The main changes are:
* Fix custom params are missing when using template or script in watcher's 
  logging action or jira action.
* Add yaml tests to test passing params to template or script successfully.

Relates to elastic#57625
jakelandis added a commit that referenced this pull request Sep 3, 2020
) (#61885)

The main changes are:
* Fix custom params are missing when using template or script in watcher's 
  logging action or jira action.
* Add yaml tests to test passing params to template or script successfully.

Relates to #57625

Co-authored-by: bellengao <[email protected]>
@andreidan andreidan added the >bug label Oct 8, 2020
@fbaligand
Copy link
Contributor

Nice!
Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants