Remove minimumRuntime sourceSet from build-tools #58417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
changed the title
breskeby
commented
Jun 23, 2020
| @@ -66,7 +65,6 @@ public void execute(Task task) { | |||
| } | |||
| } | |||
|
|
|||
| @Internal | |||
Contributor
Author
There was a problem hiding this comment.
that slipped through in the extra sourceSet before as gradles validateProperties task didn't catch it. by moving this to the main sourceSet now we need to fix it here to have :buildSrc:validateProperties pass
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jun 24, 2020
* Remove minimumRuntime sourceSet from build-tools * remove license change in loggedexec task
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 1, 2020
* Remove minimumRuntime sourceSet from build-tools * remove license change in loggedexec task
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 1, 2020
* Remove minimumRuntime sourceSet from build-tools * remove license change in loggedexec task
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58351