Make parent and child aggregator more obvious #57490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls the way that the `ParentJoinAggregator` collects global ordinals into a strategy object so it is a little simpler to reason about and it'll be simpler to save memory by removing `asMultiBucketAggregator` in the future. Relates to elastic#56487
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
16 tasks
talevy
approved these changes
Jun 1, 2020
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
super minor copy-paste nit in a doc, but otherwise. I like the clearer cleanup!
| */ | ||
| protected class DenseCollectionStrategy implements CollectionStrategy { | ||
| /** | ||
| * Otherwise we use a dense bit array to record the global ordinals. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jun 2, 2020
Pulls the way that the `ParentJoinAggregator` collects global ordinals into a strategy object so it is a little simpler to reason about and it'll be simpler to save memory by removing `asMultiBucketAggregator` in the future. Relates to elastic#56487
nik9000
added a commit
that referenced
this pull request
Jun 2, 2020
Pulls the way that the `ParentJoinAggregator` collects global ordinals into a strategy object so it is a little simpler to reason about and it'll be simpler to save memory by removing `asMultiBucketAggregator` in the future. Relates to #56487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the way that the
ParentJoinAggregatorcollects global ordinalsinto a strategy object so it is a little simpler to reason about and
it'll be simpler to save memory by removing
asMultiBucketAggregatorinthe future.
Relates to #56487