[DOCS] Relocate discovery module content #56611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moves `Discovery and cluster formation` content from `Modules` to `Set up Elasticsearch`. * Combines `Adding and removing nodes` with `Adding nodes to your cluster`. Adds related redirect. * Removes and redirects the `Modules` page. * Rewrites parts of `Discovery and cluster formation` to remove `module` references and meta references to the section.
jrodewig
added
>docs
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
jrodewig
commented
May 12, 2020
|
|
||
| For more information about discovery and shard allocation, see | ||
| <<modules-discovery>> and <<modules-cluster>>. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Note to reviewers: This content is from https://github.com/elastic/elasticsearch/pull/56611/files#diff-e8465aac40349b409bae92fb299814f3 with no substantive changes.
Only [discrete] tags were added.
4 tasks
debadair
approved these changes
May 12, 2020
Contributor
debadair
left a comment
debadair
left a comment
There was a problem hiding this comment.
Woot! Exciting to see the end of the modules section!
docs/reference/redirects.asciidoc
Outdated
|
|
||
| This page has been removed. | ||
|
|
||
| For circuit breaker settings, see <<circuit-breaker>>. |
Contributor
There was a problem hiding this comment.
I'd probably pare this down to a simple list instead of repeating "For xyz settings" for each xref. Something like:
See <<settings, Configuring Elasticsearch>> for settings information:
* <<modules-cluster>>
* <<modules-dicsovery-settings>>
...
OTOH, this isn't a high-traffic page, so...leaving it as-is is fine, too.
Contributor
Author
There was a problem hiding this comment.
This is a good idea and much more readable IMO. Updated with 3068f21. Thanks for the suggestion!
Contributor
Author
|
Thanks as always @debadair. Happy to see this one go! 🎉 |
This was referenced Jun 1, 2020
jrodewig
added a commit
that referenced
this pull request
Jun 1, 2020
* Moves `Discovery and cluster formation` content from `Modules` to `Set up Elasticsearch`. * Combines `Adding and removing nodes` with `Adding nodes to your cluster`. Adds related redirect. * Removes and redirects the `Modules` page. * Rewrites parts of `Discovery and cluster formation` to remove `module` references and meta references to the section.
jrodewig
added a commit
that referenced
this pull request
Jun 1, 2020
* Moves `Discovery and cluster formation` content from `Modules` to `Set up Elasticsearch`. * Combines `Adding and removing nodes` with `Adding nodes to your cluster`. Adds related redirect. * Removes and redirects the `Modules` page. * Rewrites parts of `Discovery and cluster formation` to remove `module` references and meta references to the section.
jrodewig
added a commit
that referenced
this pull request
Jun 1, 2020
* Moves `Discovery and cluster formation` content from `Modules` to `Set up Elasticsearch`. * Combines `Adding and removing nodes` with `Adding nodes to your cluster`. Adds related redirect. * Removes and redirects the `Modules` page. * Rewrites parts of `Discovery and cluster formation` to remove `module` references and meta references to the section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
Discovery and cluster formationcontent fromModulestoSet up Elasticsearch.Combines
Adding and removing nodeswithAdding nodes to your cluster. Adds related redirect.Removes and redirects the
Modulespage.Rewrites parts of
Discovery and cluster formationto removemodulereferences and meta references to the section.
Closes #53303