Skip to content

[DOCS] Add release notes for 7.8.0#56340

Merged
pugnascotia merged 24 commits intoelastic:7.8from
pugnascotia:7-8-release-notes
Jun 12, 2020
Merged

[DOCS] Add release notes for 7.8.0#56340
pugnascotia merged 24 commits intoelastic:7.8from
pugnascotia:7-8-release-notes

Conversation

@pugnascotia
Copy link
Copy Markdown
Contributor

@pugnascotia pugnascotia commented May 7, 2020

Add release notes for 7.8.0.

Preview

https://elasticsearch_56340.docs-preview.app.elstc.co/diff

@pugnascotia pugnascotia added >docs General docs changes v7.8.0 labels May 7, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 7, 2020
@pugnascotia pugnascotia marked this pull request as draft May 7, 2020 13:04
@pugnascotia pugnascotia changed the base branch from 7.x to 7.8 May 13, 2020 11:10
@pugnascotia pugnascotia marked this pull request as ready for review June 10, 2020 12:16
@pugnascotia
Copy link
Copy Markdown
Contributor Author

I'd appreciate a review on this, as although there's still a couple outstanding PRs, the rest can be reviewed.

@jrodewig jrodewig requested review from jrodewig and lcawl June 10, 2020 12:26
@pugnascotia
Copy link
Copy Markdown
Contributor Author

Re: the CI failure, I confess I'm not sure what I'm doing here with references, so I'd appreciate any guidance here.

Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. However, there are a few PRs that need to be removed.

I also left some suggestions for replacing the internal xrefs with the equivalent external link. Changing those should fix the broken docs CI test.

The remaining edits are mostly non-blocking nits.

I also tagged @lcawl and @szabosteve on ML-related sections. I'll defer to them on those .

pugnascotia and others added 2 commits June 10, 2020 15:12
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
@lcawl
Copy link
Copy Markdown
Member

lcawl commented Jun 11, 2020

FYI I merged the extra machine learning PRs from https://raw.githubusercontent.com/elastic/ml-cpp/7.8/docs/CHANGELOG.asciidoc

@@ -173,6 +173,37 @@ Machine Learning::
* Skip daily maintenance activity if upgrade mode is enabled {pull}54565[#54565] (issue: {issue}54326[#54326])
* Start gathering and storing inference stats {pull}53429[#53429]
* Unassign DFA tasks in SetUpgradeModeAction {pull}54523[#54523] (issue: {issue}54326[#54326])
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcawl what is the official docs position on using the DFA acronym in public documentation? If it isn't supposed to be used then it should be expanded to "data frame analytics" here.

Copy link
Copy Markdown
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the ML related parts and left some suggestions. Thank you!

jrodewig and others added 5 commits June 11, 2020 08:40
Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
Co-authored-by: Tim Vernum <tim@adjective.org>
@pugnascotia
Copy link
Copy Markdown
Contributor Author

I've addressed the final outstanding questions. Please let me know if there is anything further to address.

Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for iterating on this @pugnascotia

@pugnascotia pugnascotia merged commit d53739d into elastic:7.8 Jun 12, 2020
@pugnascotia pugnascotia deleted the 7-8-release-notes branch June 12, 2020 13:00
jrodewig added a commit that referenced this pull request Jun 12, 2020
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>
Co-authored-by: Tim Vernum <tim@adjective.org>
Co-authored-by: lcawl <lcawley@elastic.co>
@jrodewig jrodewig changed the title Add release notes for 7.8.0 [DOCS] Add release notes for 7.8.0 Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes Team:Docs Meta label for docs team v7.8.0 v7.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants