[7.x][ML] More advanced model snapshot retention options#56194
Merged
droberts195 merged 2 commits intoelastic:7.xfrom May 5, 2020
Merged
[7.x][ML] More advanced model snapshot retention options#56194droberts195 merged 2 commits intoelastic:7.xfrom
droberts195 merged 2 commits intoelastic:7.xfrom
Conversation
This PR implements the following changes to make ML model snapshot retention more flexible in advance of adding a UI for the feature in an upcoming release. - The default for `model_snapshot_retention_days` for new jobs is now 10 instead of 1 - There is a new job setting, `daily_model_snapshot_retention_after_days`, that defaults to 1 for new jobs and `model_snapshot_retention_days` for pre-7.8 jobs - For days that are older than `model_snapshot_retention_days`, all model snapshots are deleted as before - For days that are in between `daily_model_snapshot_retention_after_days` and `model_snapshot_retention_days` all but the first model snapshot for that day are deleted - The `retain` setting of model snapshots is still respected to allow selected model snapshots to be retained indefinitely Backport of elastic#56125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following changes to make ML model snapshot
retention more flexible in advance of adding a UI for the feature in
an upcoming release.
model_snapshot_retention_daysfor new jobs is now10 instead of 1
daily_model_snapshot_retention_after_days,that defaults to 1 for new jobs and
model_snapshot_retention_daysfor pre-7.8 jobs
model_snapshot_retention_days, allmodel snapshots are deleted as before
daily_model_snapshot_retention_after_daysand
model_snapshot_retention_daysall but the first model snapshotfor that day are deleted
retainsetting of model snapshots is still respected to allowselected model snapshots to be retained indefinitely
Backport of #56125