Make xpack.monitoring.enabled setting a no-op #55617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamrandolph
added
:Core/Infra/Plugins
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Plugins) |
Contributor
Author
|
@elasticmachine test this please |
pugnascotia
approved these changes
Apr 23, 2020
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Apr 30, 2020
* Make xpack.monitoring.enabled setting a no-op This commit turns xpack.monitoring.enabled into a no-op. Mostly, this involved removing the setting from the setup for integration tests. Monitoring may introduce some complexity for test setup and teardown, so we should keep an eye out for turbulence and failures * Docs for making deprecated setting a no-op
williamrandolph
added a commit
that referenced
this pull request
May 1, 2020
* Make xpack.monitoring.enabled setting a no-op This commit turns xpack.monitoring.enabled into a no-op. Mostly, this involved removing the setting from the setup for integration tests. Monitoring may introduce some complexity for test setup and teardown, so we should keep an eye out for turbulence and failures * Docs for making deprecated setting a no-op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #54816, we deprecated a group of toggle settings for basic license level features. In #55416 (in review), we are turning most of those settings into no-ops, i.e., having them in your settings file won't throw an error, but they won't do anything at all. Turning monitoring and ILM into no-ops affects logic in other modules, so I handled them separately. ILM is in #55592, and Monitoring is handled here.
This PR turns
xpack.monitoring.enabledinto a no-op. Mostly, this involved removing the setting from the setup for integration tests. Monitoring may introduce some complexity for test setup and teardown, so we should keep an eye out for turbulence and failures, e.g. #55461 .Meta issue: #54745