Skip to content

Fix and unmute testSetUpgradeMode_ExistingTaskGetsUnassigned #55368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
przemekwitek merged 4 commits into from
Apr 20, 2020
Merged

Fix and unmute testSetUpgradeMode_ExistingTaskGetsUnassigned #55368

przemekwitek merged 4 commits into from
Apr 20, 2020

Conversation

@przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Apr 17, 2020

This PR wraps GetDataFrameAnalyticsStatsAction calls in assertBusy so that intermittent search failures do not affect test results.

More insights in the related GH issue linked below.

Relates #55221

@przemekwitek przemekwitek added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.8.0 labels Apr 17, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 17, 2020

Pinging @elastic/ml-core (:ml)

droberts195
droberts195 approved these changes Apr 17, 2020
View reviewed changes
Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek
Copy link
Contributor Author

przemekwitek commented Apr 17, 2020

I've just noticed that assertBusy only hides AssertionError, not ElasticsearchException. So this PR as it is, may not fix the issue.

@przemekwitek
Copy link
Contributor Author

przemekwitek commented Apr 17, 2020

run elasticsearch-ci/bwc

@przemekwitek przemekwitek force-pushed the upgrade_mode_assert_busy branch from 88cc194 to 4de370b Compare April 20, 2020 08:46
@przemekwitek
Copy link
Contributor Author

przemekwitek commented Apr 20, 2020

I've just noticed that assertBusy only hides AssertionError, not ElasticsearchException. So this PR as it is, may not fix the issue.

I've fixed that by catching ElasticsearchException and calling Assert.fail (which throws AssertionError making the assertBusy retry).

@przemekwitek przemekwitek merged commit 16a141b into elastic:master Apr 20, 2020
@przemekwitek przemekwitek deleted the upgrade_mode_assert_busy branch April 20, 2020 10:39
@przemekwitek przemekwitek mentioned this pull request Apr 20, 2020
Merged
przemekwitek added a commit that referenced this pull request Apr 20, 2020
@przemekwitek
Fix and unmute testSetUpgradeMode_ExistingTaskGetsUnassigned (#55368) (…
7d5f74e 
…#55452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@droberts195 droberts195 droberts195 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.8.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@przemekwitek @elasticmachine @droberts195 @jakelandis