Skip to content

Conversation

@benwtrent
Copy link
Member

When a anomaly jobs, datafeeds, and analytics tasks are stopped, they enter an ephemeral state called STOPPING.

If the node executing the task fails while this is occurring, they could be stuck in the limbo state of STOPPING. It is best to mark the tasks as completed if they get reassigned to a node.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent changed the title [ML] do not start stopping tasks on reassignment [ML] mark stopping tasks as complete on reassignment Apr 16, 2020
@benwtrent benwtrent marked this pull request as ready for review April 16, 2020 16:46
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit d5340cc into elastic:master Apr 17, 2020
@benwtrent benwtrent deleted the feature/ml-cancel-stopping-closing-tasks branch April 17, 2020 12:02
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 17, 2020
When a anomaly jobs, datafeeds, and analytics tasks are stopped, they enter an ephemeral state called `STOPPING`. 

If the node executing the task fails while this is occurring, they could be stuck in the limbo state of `STOPPING`. It is best to mark the tasks as completed if they get reassigned to a node.
benwtrent added a commit that referenced this pull request Apr 17, 2020
When a anomaly jobs, datafeeds, and analytics tasks are stopped, they enter an ephemeral state called `STOPPING`. 

If the node executing the task fails while this is occurring, they could be stuck in the limbo state of `STOPPING`. It is best to mark the tasks as completed if they get reassigned to a node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants