Remove serialization from pipeline aggregator #55026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`master` doesn't need to talk to Elasticsearch versions before 7.8.0 so `PipelineAggregator` doesn't need to be writable *at all* in master. New pipeline aggregations don't need to worry about serializing `PipelineAggregator` at all so this drops all of it. For the most part we don't need to worry about serialization of `PipelineAggregator` at all any more. When backporting a change to an aggregator that is serialized to previous versions of Elasticsearch it *should* be fairly simple to pick a value to serialize. And the compiler *should* tell you that you need to do it. In many cases you this'll be a noop. *Hopefully* all cases. Closes elastic#53742
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
3 tasks
polyfractal
approved these changes
Apr 13, 2020
Contributor
polyfractal
left a comment
polyfractal
left a comment
There was a problem hiding this comment.
All these serialization changes hurt my brain, but I think this LGTM! Not sure I'd catch any tricky behavior in review but I didn't see any obvious foot-guns.
Also yay deletions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterdoesn't need to talk to Elasticsearch versions before 7.8.0 soPipelineAggregatordoesn't need to be writable at all in master. Newpipeline aggregations don't need to worry about serializing
PipelineAggregatorat all so this drops all of it.For the most part we don't need to worry about serialization of
PipelineAggregatorat all any more. When backporting a change to anaggregator that is serialized to previous versions of Elasticsearch it
should be fairly simple to pick a value to serialize. And the compiler
should tell you that you need to do it. In many cases you this'll be a
noop. Hopefully all cases.
Closes #53742