Allow terms agg to default to depth first #54845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you didn't explictly set `global_ordinals` execution mode we were never collecting the information that we needed to select `depth_first` based on the request so we were always defaulting to `breadth_first`. This fixes it so we collect the information.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
Member
Author
|
Thanks @jimczi |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 7, 2020
If you didn't explictly set `global_ordinals` execution mode we were never collecting the information that we needed to select `depth_first` based on the request so we were always defaulting to `breadth_first`. This fixes it so we collect the information.
nik9000
added a commit
that referenced
this pull request
Apr 7, 2020
If you didn't explictly set `global_ordinals` execution mode we were never collecting the information that we needed to select `depth_first` based on the request so we were always defaulting to `breadth_first`. This fixes it so we collect the information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you didn't explictly set
global_ordinalsexecution mode we werenever collecting the information that we needed to select
depth_firstbased on the request so we were always defaulting to
breadth_first.This fixes it so we collect the information. So we can make the choice.