Convert RestIntegTestTask to Java #54528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
reviewed
Mar 31, 2020
buildSrc/src/main/java/org/elasticsearch/gradle/test/RestIntegTestTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/test/RestIntegTestTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/test/RestIntegTestTask.java
Show resolved
Hide resolved
buildSrc/src/main/java/org/elasticsearch/gradle/test/RestIntegTestTask.java
Outdated
Show resolved
Hide resolved
mark-vieira
approved these changes
Mar 31, 2020
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 1, 2020
This commit migrates the RestIntegTestTask from groovy to Java. No changes to logic should be included, however the following changes are needed: * Move Fixture interface to Java (Java can not depend on Groovy classes) * Support lazy evaluation of non-input System parameters (can not use Groovy strings) * Use constants for system property names * Remove dead System property pass through code (the build plugin does this already)
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 1, 2020
This commit migrates the RestIntegTestTask from groovy to Java. No changes to logic should be included, however the following changes are needed: * Move Fixture interface to Java (Java can not depend on Groovy classes) * Support lazy evaluation of non-input System parameters (can not use Groovy strings) * Use constants for system property names * Remove dead System property pass through code (the build plugin does this already)
jakelandis
added a commit
that referenced
this pull request
Apr 1, 2020
This commit migrates the RestIntegTestTask from groovy to Java. No changes to logic should be included, however the following changes are needed: * Move Fixture interface to Java (Java can not depend on Groovy classes) * Support lazy evaluation of non-input System parameters (can not use Groovy strings) * Use constants for system property names * Remove dead System property pass through code (the build plugin does this already)
jakelandis
added a commit
that referenced
this pull request
Apr 1, 2020
This commit migrates the RestIntegTestTask from groovy to Java. No changes to logic should be included, however the following changes are needed: * Move Fixture interface to Java (Java can not depend on Groovy classes) * Support lazy evaluation of non-input System parameters (can not use Groovy strings) * Use constants for system property names * Remove dead System property pass through code (the build plugin does this already)
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Apr 3, 2020
This commit migrates the RestIntegTestTask from groovy to Java. No changes to logic should be included, however the following changes are needed: * Move Fixture interface to Java (Java can not depend on Groovy classes) * Support lazy evaluation of non-input System parameters (can not use Groovy strings) * Use constants for system property names * Remove dead System property pass through code (the build plugin does this already)
jakelandis
added a commit
that referenced
this pull request
Apr 3, 2020
This commit migrates the RestIntegTestTask from groovy to Java. No changes to logic should be included, however the following changes are needed: * Move Fixture interface to Java (Java can not depend on Groovy classes) * Support lazy evaluation of non-input System parameters (can not use Groovy strings) * Use constants for system property names * Remove dead System property pass through code (the build plugin does this already)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the RestIntegTestTask from groovy to Java.
No changes to logic should be included, however the following changes
are needed:
=======
I couldn't get git to track the file name change, so included a intermediate commit that makes this a bit easier to diff.