Remove unused environment from anomaly detector classes #54399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (:ml) |
davidkyle
commented
Mar 30, 2020
Member
Author
There was a problem hiding this comment.
Intellij flagged this as a get on an optional without a isPresent check which is a very valid warning. In practice I don't think we could hit an NPE here but it shows the value in the inspections if you can keep the noise level down.
dimitris-athanasiou
approved these changes
Mar 30, 2020
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
LGTM Nice! Just left an optional suggestion.
Contributor
There was a problem hiding this comment.
nit: make it a single liner using ternary?
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Mar 30, 2020
davidkyle
added a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #54371 I realised the
Environmentvariable being passed in to the various AD managers is unused.This takes removes the environment var and some minor tidying up to clean up Intellij inspection warnings