Refactor AliasOrIndex abstraction. #54394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prepare the `AliasOrIndex` abstraction for the introduction of data streams, the abstraction needs to be made more flexible, because currently it really can be only an alias or an index. * Renamed `AliasOrIndex` to `IndexAbstraction`. * Introduced a `IndexAbstraction.Type` enum to indicate what a `IndexAbstraction` instance is. * Replaced the `isAlias()` method that returns a boolean with the `getType()` method that returns the new Type enum. * Moved `getWriteIndex()` up from the `IndexAbstraction.Alias` to the `IndexAbstraction` interface. * Moved `getAliasName()` up from the `IndexAbstraction.Alias` to the `IndexAbstraction` interface and renamed it to `getName()`. * Removed unnecessary casting to `IndexAbstraction.Alias` by just checking the `getType()` method. Relates to elastic#53100
martijnvg
added
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #53982
In order to prepare the
AliasOrIndexabstraction for the introduction of data streams,the abstraction needs to be made more flexible, because currently it really can be only
an alias or an index.
AliasOrIndextoIndexAbstraction.IndexAbstraction.Typeenum to indicate what aIndexAbstractioninstance is.isAlias()method that returns a boolean with thegetType()method that returns the new Type enum.getWriteIndex()up from theIndexAbstraction.Aliasto theIndexAbstractioninterface.getAliasName()up from theIndexAbstraction.Aliasto theIndexAbstractioninterface and renamed it togetName().IndexAbstraction.Aliasby just checking thegetType()method.Relates to #53100