More pipeline aggregation cleanup #54298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the last bit of validation that pipeline aggregations performed on the data nodes with explicit checks in a few `PipelineAggregationBuilders`. We were *already* catching these validation errors for pipeline aggregations that require that their parent be squentially ordered. This just adds validation for pipelines that require *any* parent like `bucket_selector` and `bucket_sort`.
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
3 tasks
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-matrix-unix |
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-unix and run elasticsearch-ci/packaging-sample-matrix-unix |
Member
Author
|
@elasticmachine, test this please |
polyfractal
approved these changes
Apr 7, 2020
Contributor
polyfractal
left a comment
polyfractal
left a comment
There was a problem hiding this comment.
And there was much rejoicing. 🎉
Member
Author
|
Thanks @polyfractal! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 7, 2020
This replaces the last bit of validation that pipeline aggregations performed on the data nodes with explicit checks in a few `PipelineAggregationBuilders`. We were *already* catching these validation errors for pipeline aggregations that require that their parent be squentially ordered. This just adds validation for pipelines that require *any* parent like `bucket_selector` and `bucket_sort`.
nik9000
added a commit
that referenced
this pull request
Apr 7, 2020
This replaces the last bit of validation that pipeline aggregations performed on the data nodes with explicit checks in a few `PipelineAggregationBuilders`. We were *already* catching these validation errors for pipeline aggregations that require that their parent be squentially ordered. This just adds validation for pipelines that require *any* parent like `bucket_selector` and `bucket_sort`.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 7, 2020
We can run these tests again 7.8.0 now that it has the fix.
nik9000
added a commit
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the last bit of validation that pipeline aggregations
performed on the data nodes with explicit checks in a few
PipelineAggregationBuilders. We were already catching thesevalidation errors for pipeline aggregations that require that their
parent be sequentially ordered. This just adds validation for pipelines
that require any parent like
bucket_selectorandbucket_sort.