Allow proxy mode server name to be updated #54107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a bug where the proxy strategy will not be rebuilt if the server_name is dynamically updated. This commit fixes this issue.
Tim-Brooks
added
>bug
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
ywelsch
approved these changes
Mar 24, 2020
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. Note that I also added the 7.6 label
Tim-Brooks
added a commit
that referenced
this pull request
Mar 24, 2020
Currently there is a bug where the proxy strategy will not be rebuilt if the server_name is dynamically updated. This commit fixes this issue.
Tim-Brooks
added a commit
that referenced
this pull request
Mar 24, 2020
Currently there is a bug where the proxy strategy will not be rebuilt if the server_name is dynamically updated. This commit fixes this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug where the proxy strategy will not be rebuilt if
the server_name is dynamically updated. This commit fixes this issue.